[PATCH] D42898: Do not spill CSR to stack on entry to noreturn functions

pmb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 15:43:29 PST 2018


myeisha added a comment.

In https://reviews.llvm.org/D42898#998355, @efriedma wrote:

> It looks like this transform destroys stack traces on non-x86 platforms.  That technically isn't wrong, I guess, but it seems unfriendly (for example, LLVM produces a stack trace on an assertion failure).


I don't quite follow. If I force the frame pointer on (eg by storing into a frame pointer returned by `llvm.frameaddress`) I see that the old frame pointer is stacked even for noreturn nounwind functions. I'd hate to break stack traces, am I missing something?


https://reviews.llvm.org/D42898





More information about the llvm-commits mailing list