[PATCH] D42886: [GlobalISel][AArch64] Adding -disable-legality-check CL option

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin added a comment.

In https://reviews.llvm.org/D42886#997977, @bogner wrote:

> This seems like a bit of a hack compared to actually fixing the TODO and moving this check into the MachineVerifier where it belongs.


Hi Justin,

I think this patch and fixing the TODO are orthogonal to each other: moving the check into MachineVerifier doesn't solve the problem stated as it will be still impossible to actually run-pass instruction-select on a MIR file that is considered illegal by the current implementation of the legalizer, as far as I can tell. The reason being we run MachineVerifier unconditionally upon loading a MIR file, and if it includes this check, it will fail.

So making this check explicitly optional independently from other checks MachineVerifier does and including that check into the MachineVerifier are 2 different things.

What do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D42886