[PATCH] D41293: [DAG, X86] Improve Dependency analysis when doing multi-node Instruction Selection

[Justin Bogner via Phabricator via llvm-commits]

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

Seems reasonable. A couple of nitpicks.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:808
+                                   bool TopologicalPrune = false) {
+    SmallVector<const SDNode *, 16> DeferredNodes;
     if (Visited.count(N))
----------------
16 seems kind of large for the SmallVector, given that in all the cases we call this with TopologicalPrune=false will leave this empty.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:2177
+
+  return (SDNode::hasPredecessorHelper(Def, Visited, WorkList, 0, true));
 }
----------------
Extra set of parens?


Repository:
  rL LLVM

https://reviews.llvm.org/D41293