[PATCH] D42783: [DAGCombiner] When folding fold (sext/zext (and/or/xor (sextload/zextload x), cst)) -> (and/or/xor (sextload/zextload x), (sext/zext cst)) make sure we check the legality of the full extended load.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 3 12:16:44 PST 2018


craig.topper added a comment.

Maybe? I'm still trying to get my head around this code. There are some other issues we need to investigate here first. We don't call ExtendUsesToFormExtLoad when the load itself has multiple uses. Just when the AND/OR/XOR has multiple uses, but we're passing the SDValue of the load. So we'll only collect setccs when the and/or/xor has additional users and the load is used by more than just the and/or/xor.


Repository:
  rL LLVM

https://reviews.llvm.org/D42783





More information about the llvm-commits mailing list