[PATCH] D42762: Rewrite the VS Integration Scripts

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 11:49:42 PST 2018


zturner updated this revision to Diff 132644.
zturner added a comment.

1. Removed the option remapping.  I will be adding this back in a follow up patch.  The clang-cl specific "limited options view" is still here.
2. Removed the dependency on writing the version number to the registry.  This was originally done so that we could add the clang resource dir to the include path, but clang can always figure out its own resource path anyway, so it turns out this was unnecessary.  This has the nice property that it will automatically work with all past, present, and future clang versions without modification.
3. Changed "clang" to "llvm"
4. Merged https://reviews.llvm.org/D42769 into this patch.
5. Remove the batch files (and for that matter all other files as well) from being installed by CMake.  The vsix is now the installer, which we can publish on the marketplace.


https://reviews.llvm.org/D42762

Files:
  clang/tools/driver/CMakeLists.txt
  llvm/CMakeLists.txt
  llvm/tools/msbuild/.gitignore
  llvm/tools/msbuild/CMakeLists.txt
  llvm/tools/msbuild/LLVM.Cpp.Common.props
  llvm/tools/msbuild/LLVM.Cpp.Common.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2010.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2012.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2012_xp.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.llvm.props.in
  llvm/tools/msbuild/Platformx64/Toolset.props
  llvm/tools/msbuild/Platformx64/Toolset.targets
  llvm/tools/msbuild/Platformx86/Toolset.props
  llvm/tools/msbuild/Platformx86/Toolset.targets
  llvm/tools/msbuild/clang-cl.xml
  llvm/tools/msbuild/install.bat
  llvm/tools/msbuild/license.txt
  llvm/tools/msbuild/llvm.csproj
  llvm/tools/msbuild/llvm.sln
  llvm/tools/msbuild/source.extension.vsixmanifest
  llvm/tools/msbuild/toolset-vs2013.targets
  llvm/tools/msbuild/toolset-vs2013_xp.targets
  llvm/tools/msbuild/toolset-vs2014.targets
  llvm/tools/msbuild/toolset-vs2014_xp.targets
  llvm/tools/msbuild/uninstall.bat

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42762.132644.patch
Type: text/x-patch
Size: 86429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180202/b3c5fd28/attachment.bin>


More information about the llvm-commits mailing list