[PATCH] D42832: [AArch64][GlobalISel] Use getRegClassForTypeOnBank() in selectCopy.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 09:47:53 PST 2018


aemerson added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:139
+                         const RegisterBankInfo &RBI,
+                         bool GetAllRegSet = false) {
   if (RB.getID() == AArch64::GPRRegBankID) {
----------------
qcolombet wrote:
> Would it result in incorrect code if we were to always take the "all" variant?
I've discussed this with Tim who originally added this function, he thinks that we should probably keep the existing behavior and not force users to use the "all" RC. In practice I don't think it matters too much which one we pick (most of the time).


Repository:
  rL LLVM

https://reviews.llvm.org/D42832





More information about the llvm-commits mailing list