[PATCH] D42798: [ThinLTO] - Fix for "ThinLTO inlines variables that should be discarded".

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: lib/LTO/LTOBackend.cpp:410
+  };
+
+  for (auto &GV : Mod)
----------------
tejohnson wrote:
> add a FIXME comment somewhere here that we eventually want to drop dead aliases, but that this needs support in convertToDeclaration. Can you also add a FIXME into convertToDeclaration that alias support is needed for dropDeadSymbols to behave correctly for aliases? It would also be great to file a bug to track the alias handling, similar to the bug you filed for global variables for this patch.
I added comment to `dropDeadSymbols` before commit.
Will try to prepare testcase, fill the bug and add the second comment in a follow up.




https://reviews.llvm.org/D42798