[PATCH] D42635: [ELF] - Report valid binary filename when reporting error.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/duplicated-synthetic-sym.s:1-7
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 // RUN: cd %S
 // RUN: not ld.lld %t.o --format=binary duplicated-synthetic-sym.s -o %t.elf 2>&1 | FileCheck %s
 // RUN: not ld.lld %t.o --format binary duplicated-synthetic-sym.s -o %t.elf 2>&1 | FileCheck %s
 
 // CHECK: duplicate symbol: _binary_duplicated_synthetic_sym_s_start
+// CHECK: defined at duplicated-synthetic-sym.s:(.data+0x0)
----------------
ruiu wrote:
> Can you change the test? Linking an .s file as a binary file is confusing. Just create a temporary file by doing something like this
> 
>   RUN: echo abc > %t.bin
> 
> and link that file.
Done in rL324072.


https://reviews.llvm.org/D42635