[PATCH] D42417: [SCEV] Fix isLoopEntryGuardedByCond

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 01:08:15 PST 2018


mkazantsev added a comment.

I've revisited all usages of this method and think that https://reviews.llvm.org/rL323077 can be reapplied with two changes:

1. Asserts should be done after we check the `L` on `nullptr`;
2. In `isImpliedViaNoOverflow`, you should check availability of `FoundRHS` (which was not done in the initial patch).

Other places look good: the values coming as parameters there seem to be invariants avaliable on loop entry.


https://reviews.llvm.org/D42417





More information about the llvm-commits mailing list