[PATCH] D42814: [buildbot] Updated CUDA buildbot config.

Galina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 14:20:52 PST 2018


gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

LGTM.
There is a cosmetic issue, but your change seems in line with the rest of the file, so, not sure if you would want to do this just for 2 ninja commands you are adding, or address it everywhere in this file as a separate patch.



================
Comment at: zorg/buildbot/builders/CUDATestsuiteBuilder.py:157
+                haltOnFailure=True,
+                description=["Running simple CUDA tests on GPU %s" % gpu_id],
+                descriptionDone=["simple CUDA tests on GPU %s done." % gpu_id],
----------------
Here and in all the similar cases. It is better to have the description as an array of words, as it helps buildbot to format multiline text for compact views.


https://reviews.llvm.org/D42814





More information about the llvm-commits mailing list