[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 13:35:10 PST 2018


On Thu, Feb 1, 2018 at 1:33 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Michael Spencer <bigcheesegs at gmail.com> writes:
>
> > This will only work if the local symbols show up once across all inputs,
> > otherwise it will just take the last one. Not really an issue for
> testing,
> > but it will do the wrong thing in the general case.
>
> It is the same constraint that we have with --symbol-ordering-file, so
> it seems reasonable to me.
>

Agreed. I want to fix both in some way, though.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/cde8cdba/attachment.html>


More information about the llvm-commits mailing list