[llvm] r323996 - [AArch64] remove bogus comment; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 11:59:33 PST 2018


Author: spatel
Date: Thu Feb  1 11:59:33 2018
New Revision: 323996

URL: http://llvm.org/viewvc/llvm-project?rev=323996&view=rev
Log:
[AArch64] remove bogus comment; NFC

I added this comment with D42323, but as discussed in D42806, the architecture
does the right thing for denorms. We don't even need the select on 0.0 here?

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp

Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp?rev=323996&r1=323995&r2=323996&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp Thu Feb  1 11:59:33 2018
@@ -5007,9 +5007,6 @@ SDValue AArch64TargetLowering::getSqrtEs
         Step = DAG.getNode(AArch64ISD::FRSQRTS, DL, VT, Operand, Step, Flags);
         Estimate = DAG.getNode(ISD::FMUL, DL, VT, Estimate, Step, Flags);
       }
-      // FIXME: This does not detect denorm inputs, so we might produce INF
-      // when we should produce 0.0. Try to refactor the code in DAGCombiner,
-      // so we don't have to duplicate it here.
       if (!Reciprocal) {
         EVT CCVT = getSetCCResultType(DAG.getDataLayout(), *DAG.getContext(),
                                       VT);




More information about the llvm-commits mailing list