[PATCH] D42443: [SymbolFilePDB] Add support for function symbols

[Zachary Turner via llvm-commits]

Yea good point. We can probably punt on this for now as it’s just a
nice-to-have
On Thu, Feb 1, 2018 at 1:38 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added inline comments.
>
>
> ================
> Comment at: lit/SymbolFile/PDB/func-symbols.test:4
> +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/FuncSymbols.cpp /o
> %T/FuncSymbols.cpp.obj
> +RUN: link %T/FuncSymbolsTestMain.cpp.obj %T/FuncSymbols.cpp.obj /DEBUG
> /nodefaultlib /Entry:main /OUT:%T/FuncSymbolsTest.exe
> +RUN: lldb-test symbols %T/FuncSymbolsTest.exe | FileCheck %s
> ----------------
> zturner wrote:
> > I bet we could get rid of `REQUIRES: windows` if we changed this to
> `lld-link`.  You're already specifying `/nodefaultlib /entry:main`, and no
> windows header files are included, so maybe it's worth a try?
> That would be great, but you'd probably still need something like
> REQUIRES:lld, as lld is not currently not a mandatory requirement for
> building/testing.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D42443
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/b0df16e2/attachment.html>