[PATCH] D42802: [DWARF] Regularize dumping strings from line tables.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:443
+  if (OS) {
+    DIDumpOptions DumpOptions;
+    DumpOptions.Verbose = true;
----------------
JDevlieghere wrote:
> Maybe add a comment here that says that if we execute this path we know we're in verbose mode. Alternatively we could add the `DumpOptions` as an additional default argument but I don't think that's worth it here. 
There is a comment to that effect elsewhere, which is why I knew this call should use verbose mode.  The line table dumping is weird that way.  But a comment here as well would make sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D42802