[PATCH] D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168)

[Momchil Velikov via Phabricator via llvm-commits]

chill updated this revision to Diff 132415.
chill edited the summary of this revision.
chill added a comment.

Changes relative to the previous version:

- Signed/unsigned flag stored inside `SubclassData32` member of `DIEnumerator`.
- Metadata for `DIEnumerator` is back to 3-element record. The signed/unsigned flag is stored in bit #1 of the first record element. Since it looked a bit weird to store `IsSigned` value of `true` as `0`, ...
- ... changed everywhere `IsSigned` to `IsUnsigned`
- removed the upgrade test, as the bitcode format doesn't actually change now


https://reviews.llvm.org/D42734

Files:
  include/llvm/Bitcode/LLVMBitCodes.h
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoFlags.def
  include/llvm/IR/DebugInfoMetadata.h
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/MetadataLoader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/IR/LLVMContextImpl.h
  test/DebugInfo/Generic/debug-info-enum.ll
  test/DebugInfo/X86/enum-class.ll
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42734.132415.patch
Type: text/x-patch
Size: 27638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/02db42f6/attachment.bin>