[PATCH] D42468: [lldb][PPC64] Fixed vector and struct return value

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 06:33:40 PST 2018


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I think this looks good. Thank you for standing by.



================
Comment at: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp:454
+      ss.flush();
+      return regName;
+    }
----------------
This can be even shorter, like: `return ("r" + llvm::Twine(m_index+3)).str();` The str() may not even be necessary (I don't know if Twine is implicitly convertible here off-hand).


https://reviews.llvm.org/D42468





More information about the llvm-commits mailing list