[PATCH] D42769: Create a VSIX Installer for the VS Integration

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/tools/msbuild/install.bat:9
 
 REM Older versions of VS would look for these files in the Program Files\MSBuild directory
 REM but with VS2017 it seems to look for these directly in the Visual Studio instance.
----------------
Oh I see, this is based on top off D42762 which isn't landed yet. I'll review that first then :-)


================
Comment at: llvm/tools/msbuild/uninstall.bat:8
 
-set PLATFORM=None
-:LOOPHEAD
-IF %PLATFORM% == x64 GOTO LOOPEND
-IF %PLATFORM% == Win32 SET PLATFORM=x64
-IF %PLATFORM% == None SET PLATFORM=Win32
+SET VCTargets=%ProgramFiles(x86)%\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\VCTargets
 
----------------
I thought we also wanted to support VS 2015?


================
Comment at: llvm/tools/msbuild/uninstall.bat:15
+ECHO Uninstalling x64 Platform Toolset
+SET PlatformToolsets=%VCTargets%\Platforms\x64\PlatformToolsets
+IF EXIST "%PlatformToolsets%\llvm\Toolset.props" del "%PlatformToolsets%\llvm\Toolset.props"
----------------
Does this need quotes? Same for the SET in the next section.


https://reviews.llvm.org/D42769