[llvm] r323923 - [llvm-cov] Fix incorrect usage of .precision specifier in format() call.

[Vedant Kumar via llvm-commits]

Thanks for the fix :). FWIW for smaller changes like this, I think it'd be fine to skip the Phab step.

vedant

> On Jan 31, 2018, at 2:13 PM, Max Moroz via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: dor1s
> Date: Wed Jan 31 14:13:07 2018
> New Revision: 323923
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=323923&view=rev
> Log:
> [llvm-cov] Fix incorrect usage of .precision specifier in format() call.
> 
> Summary: Existing version doesn't work on Windows as it always prints 0.00.
> 
> Reviewers: Dor1s
> 
> Reviewed By: Dor1s
> 
> Subscribers: llvm-commits
> 
> Differential Revision: https://reviews.llvm.org/D42767
> 
> Modified:
>    llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
> 
> Modified: llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp?rev=323923&r1=323922&r2=323923&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp (original)
> +++ llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp Wed Jan 31 14:13:07 2018
> @@ -343,7 +343,7 @@ void CoveragePrinterHTML::emitFileSummar
>     {
>       raw_string_ostream RSO{S};
>       if (Total)
> -        RSO << format("%6.2f", 7, Pctg) << "% ";
> +        RSO << format("%*.2f", 7, Pctg) << "% ";
>       else
>         RSO << "- ";
>       RSO << '(' << Hit << '/' << Total << ')';
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits