[PATCH] D42323: [DAGCombiner] filter out denorm inputs when calculating sqrt estimate (PR34994)

Evandro Menezes via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 15:09:16 PST 2018


Hi, Sanjay.

The patch LGTM, but, when trying on AArch64, I didn't see any difference 
in the AArch64 test case in attach. I'm confused...

-- 
Evandro Menezes

On 01/26/2018 12:01 PM, Sanjay Patel via Phabricator via llvm-commits wrote:
> spatel added a reviewer: bkramer.
> spatel added a comment.
>
> Ping.
>
> Note that on x86 Linux, specifying -fdenormal-fp-math=ieee doesn't inhibit linking crtfastmath.o ( https://reviews.llvm.org/rL165240 / https://bugs.llvm.org/show_bug.cgi?id=14024 ), but I think that's a separate issue. (No matter what we do here in codegen, denormals will be off on that platform.)
>
>
> https://reviews.llvm.org/D42323
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/e5ae5782/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sqrt-fastmath.diff
Type: text/x-patch
Size: 1997 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/e5ae5782/attachment.bin>


More information about the llvm-commits mailing list