[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rui Ueyama via llvm-commits]

Sorry for the belated response

I experienced perhaps too many problems with this patch, for example, it's
was too unstable (it sometimes crashes), it didn't compile in the first
place, it lacked the instructions how to test it, it lacked some required
file, etc. and it just took too much time even to just run it. Do you mind
if I ask you to prepare a patch more carefully? Ideally it should come with
a script that builds everything from source with and without profile-guided
optimization to demonstrate the feature, as I partly did in my github
repository for you.

On Wed, Jan 31, 2018 at 12:50 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:
>
> > Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:
> >
> >> The patch needs to be rebased and clang formatted
> >>
> >> We should start with a version that doesn't depend on the llvm side, as
> >> there are too many moving pieces right now.
> >>
> >> I have started working on the above.
> >
> > OK, I have a patch against lld trunk that I can build standalone. I will
> > test it with perf generated call graphs and report.
>
> I am getting a crash when trying to link lld itself.
>
> The testcase is at
> https://s3-us-west-2.amazonaws.com/linker-tests/t.tar.xz.
>
> Please take a look and upload a new version of the patch I emailed. That
> is: read callgrah from a text file and no dependencies on llvm changes.
>
> The error also happens with --no-threads. The valgrind reported errors
> are attached.
>
>
>
> Cheers,
> Rafael
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/0ece038d/attachment.html>