[PATCH] D42765: [DebugInfo] Support DWARFv5 source code embedding extension

[David Blaikie via llvm-commits]

On Wed, Jan 31, 2018 at 2:08 PM Adrian Prantl via Phabricator <
reviews at reviews.llvm.org> wrote:

> aprantl added inline comments.
>
>
> ================
> Comment at: include/llvm/IR/DebugInfoMetadata.h:512
>    ChecksumKind CSKind;
> +  Optional<MDString *> Source;
>
> ----------------
> It is probably better to make DIFile variable length so we don't have to
> pay for the extra pointer when we don't need it.
>

Yeah, likely - any idea what the overhead is to variable length? (is there
any overhead? I guess maybe not)


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D42765
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/0e2679c2/attachment.html>