[PATCH] D42765: [DebugInfo] Support DWARFv5 source code embedding extension

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/BinaryFormat/Dwarf.def:750
 HANDLE_DW_LNCT(0x05, MD5)
+HANDLE_DW_LNCT(0x2001, has_source)
+HANDLE_DW_LNCT(0x2002, source)
----------------
How did you come up with the number?
Are you reasonably sure that no one else is using it?
Perhaps add a prefix like LLVM_ or AMDGPU_ to the constants?


================
Comment at: test/Bitcode/metadata-source.ll:16
+
+!3 = !DIFile(filename: "a.c", directory: "/home/slinder1/test/link", source: "int a;\0A")
+!4 = !{}
----------------
The test with the .bc file in test/Bitcode should be to make sure we correctly upgrade the old format.

To test the new format, there should be a round-trip test in test/IR that does llvm-as | llvm-dis | llvm-as | llvm-dis.


Repository:
  rL LLVM

https://reviews.llvm.org/D42765