[PATCH] D42707: [DWARFv5] Emit .debug_line_str (in a non-DWO file)

[David Blaikie via llvm-commits]

On Wed, Jan 31, 2018 at 11:42 AM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: llvm/test/MC/ELF/debug-md5.s:20-25
> +# CHECK: .debug_line_str contents:
> +# CHECK-NEXT: 0x00000000: ""
> +# CHECK-NEXT: 0x00000001: "dir1"
> +# CHECK-NEXT: 0x00000006: "dir2"
> +# CHECK-NEXT: 0x0000000b: "foo"
> +# CHECK-NEXT: 0x0000000f: "bar"
> ----------------
> probinson wrote:
> > dblaikie wrote:
> > > Any way to test that the line table is actually using the indexes into
> the debug_line_str section?
> > Maybe, when printing the directory/file names we could print the
> section+index when they're indirect.  I'll look into that.
> So, this would be a missing feature in llvm-dwarfdump, which doesn't
> provide a way to dump the section/index pointed to by an indirect reference
> in the line table (like it does in .debug_info).  In fact by the time we're
> dumping the line table header, the relevant information is long gone.
> That should be its own patch.  Follow-up, or put this on hold to wait for
> it?
>

Whichever suits you


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D42707
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/f1da462f/attachment.html>