[PATCH] D42095: [WebAssembly] Output provisional table to match LLD relocatable output

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:502
-    if (!IndirectSymbolIndices.count(RelEntry.Symbol))
-      report_fatal_error("symbol not found in table index space: " +
-                         RelEntry.Symbol->getName());
----------------
ncw wrote:
> sbc100 wrote:
> > I guess this error was removed because it should never happen right?
> > 
> > And converting it to an assert wouldn't be very useful?
> > 
> Hmm, maybe it would be better to keep the check. In fact, there are several places where we do a check using "!thing.count()", when we could instead be using "find" to do the lookup only once. That would be ideal I guess, maybe with "findOrAbort" static helper function.
Doesn't std::vector::operator[] effectively give us the "findOrAbort" semantics?

I think I originally added this nice errors to aid debugging, but if they shouldn't ever  occur in practice then we should probably at most use a single assert (and perhaps just really on std::vector to blow up for us?)


Repository:
  rL LLVM

https://reviews.llvm.org/D42095