[PATCH] D42750: [WebAssembly] Pre-symtab tidy of LLVM globals. NFC.

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 11:00:36 PST 2018


ncw created this revision.
ncw added reviewers: sbc100, dschuff.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google, jfb.

- Remove dead code for handling the .global_variables section in WasmObjectWriter, which is unused and won't work anyway because it doesn't generate relocations for the variables
- Factored out common struct WasmGlobalType, which matches the name for that tuple in the Wasm spec
- Renamed some methods to "isBindingGlobal", "isTypeGlobal" to avoid ambiguity


Repository:
  rL LLVM

https://reviews.llvm.org/D42750

Files:
  include/llvm/BinaryFormat/Wasm.h
  include/llvm/Object/Wasm.h
  lib/MC/WasmObjectWriter.cpp
  lib/Object/WasmObjectFile.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h
  tools/obj2yaml/wasm2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42750.132212.patch
Type: text/x-patch
Size: 11691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/3c761df6/attachment.bin>


More information about the llvm-commits mailing list