[PATCH] D42746: MIR PhysReg sigil change from '%' to '$'

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 10:56:38 PST 2018


thegameg accepted this revision.
thegameg added a comment.

Thanks!

I think MIRLangRef <http://llvm.org/docs/MIRLangRef.html> needs to be updated, but other than that, LGTM!



================
Comment at: lib/CodeGen/MIRParser/MILexer.cpp:422
+
+    // ErrorCallback(Token.location(), "Named vregs are not yet supported.");
+    return None;
----------------
The plan is to turn this on at some point?


Repository:
  rL LLVM

https://reviews.llvm.org/D42746





More information about the llvm-commits mailing list