[PATCH] D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 09:28:34 PST 2018


aprantl added a comment.

Thanks!

>From what I can tell this is missing a bitcode upgrade in MetadataLoader to parse the old format and upgrade it (e.g, by treating everything as signed, similar to how our current implementation works).
Can you add that and a bitcode upgrade test to test/Bitcode that exercises it?

Do you need to add any additional checks to the IR Verifier?


Repository:
  rL LLVM

https://reviews.llvm.org/D42734





More information about the llvm-commits mailing list