[PATCH] D42713: LTO: Include dso-local bit in ThinLTO cache key.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:181
+    for (const ValueInfo &VI : GS->refs()) {
+      AddUnsigned(VI.isDSOLocal());
       AddUsedCfiGlobal(VI.getGUID());
----------------
Is it necessary to do this for all refs, rather than just for each DefinedGlobals summary (like we do for the linkage below)?


================
Comment at: llvm/test/LTO/Resolution/X86/cache-dso-local.ll:9
+; RUN:   -r %t.bc,bar,px
+; RUN: ls %t.cache | count 2
+
----------------
comment please


https://reviews.llvm.org/D42713