[PATCH] D42082: Add DWARF for discriminated unions

Tom Tromey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 05:31:50 PST 2018


tromey added a comment.

In https://reviews.llvm.org/D42082#992224, @aprantl wrote:

> As far as the metadata changes are concerned this looks mostly good, what's missing is a
>
> - round-trip test of the assembler (similar to test/Assembler/dicompositetype-members.ll )\


I looked at the patch again, and I thought that the changes to test/Assembler/debug-info.ll were sufficient here.
If that's not the case, can you tell me what I'd have to change?


Repository:
  rL LLVM

https://reviews.llvm.org/D42082





More information about the llvm-commits mailing list