[PATCH] D42600: [WIP][Shrink-wrap]split restore point

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 17:10:08 PST 2018


qcolombet added a comment.

Just two remarks:

- So far shrink-wrapping was solely an analysis pass, i.e., it didn't modify the input code
- Ideally I'd like we postpone creating new blocks until we decided where we are going to insert the code, otherwise we'll end up with blocks to clean-up later on

Regarding the SESE approach, I think it wouldn't be enough because what you want and not given by SESE is *new* common (post)dominator. E.g., in the motivating example we wanted to merge (A->C) (B->C) into (A->common) (B->common) (common->C).


https://reviews.llvm.org/D42600





More information about the llvm-commits mailing list