[PATCH] D34135: [JumpThreading] Use DT to avoid processing dead blocks

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 16:06:19 PST 2018


brzycki added a comment.

In https://reviews.llvm.org/D34135#991901, @dberlin wrote:

> (also, the DT was not updated at all prior during JT prior to all of these patches, so i guess it all worked because LVI didn't use DT when called from JumpThreading or something)?


I've created https://reviews.llvm.org/D42717 in response to PR 36133.

As to your assumption I believe you are correct. LVI will perform more expensive checks if DT isn't available and I think that's what happened in the past. I'm still confused why I see the same regression for the addition of AA to JumpThreading last March but I'm more concerned about making tip not miscompile.


https://reviews.llvm.org/D34135





More information about the llvm-commits mailing list