[PATCH] D42630: Add interceptors for readlinkat, name_to_handle_at, open_by_handle_at

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 13:20:36 PST 2018


vitalybuka added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Linux/readlink.cc:1
+// RUN: %clangxx -m64 -O0 -g -xc++ %s -o %t && %run %t
+// REQUIRES: x86_64-target-arch
----------------
vitalybuka wrote:
> krytarowski wrote:
> > krytarowski wrote:
> > > This test should be available for all POSIX systems.
> > > 
> > > It works on NetBSD as it is.
> > It might be a good idea to split the readlink(2) and readlinkat(2) into separate tests.
> > Also this -m64 should be dropped.
> sgtm
> Kamil, would you like to do so and land the patch?
> No problem If not. I will split myself. I just have nothing other than Linux.
Don't bother, I am going to that myself.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42630





More information about the llvm-commits mailing list