[PATCH] D41669: Use ODR debug type uniquing when enabled during function cloning

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D41669#992020, @pcc wrote:

> Sorry the value mapper version mostly looks good. One question.
>
>   if (CT && CT->getIdentifier() != "") {
>   + auto *NewCT = DICompositeType::buildODRType
>
>
> Can this be `if (enableodruniquing() && CT && ...) Return CT;`?


Not sure what you mean - we don't want to return the source's CT. (And the first thing buildODRType does is check if ODR uniquing is enabled, so no need to check that here too).

I'll go ahead and update the patch with the new version.


https://reviews.llvm.org/D41669