[PATCH] D42683: [AggressiveInstCombine] fixed PR36134

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

Nit: when proposing patches and writing the commit message, make the title be more descriptive than 'Fixed Bug ###'. Ie, the title should be something like the summary text shown here:
"Make TruncCombine class ignore unreachable basic blocks"

...and then add some motivation in the summary:
"because dead code may contain non-standard IR that causes infinite looping or crashes in underlying analysis. See PR### for more details."

That lets people who are scanning the mailing list or doing bisection archaeology know quickly what this commit is doing and why.


https://reviews.llvm.org/D42683