[PATCH] D42671: Sort orphan section if --symbol-ordering-file is given

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Not sure if this is what motivated your change, but I think this will allow me to make some improvements to https://reviews.llvm.org/D42475.

Personally, I'm not convinced that we should ignore the symbol-ordering-file for non-orphaned sections, since it's more likely, I feel, for people to use linker scripts "by default" than the ordering file, but this is not really part of this change.



================
Comment at: ELF/LinkerScript.cpp:256
     MutableArrayRef<InputSection *> Vec, const SectionPattern &Pat,
     const DenseMap<SectionBase *, int> &Order) {
   if (Pat.SortOuter == SortSectionPolicy::None)
----------------
Order isn't used here after this change, so it can be removed from this function plus a number of functions in the call stack, which in turn allows us to remove the buildSectionOrder call in processSectionCommands.


https://reviews.llvm.org/D42671