[PATCH] D42468: [lldb][PPC64] Fixed vector and struct return value

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 05:02:04 PST 2018


labath added a comment.

Normally you should only format the lines you touch (if you use git, there's `git clang-format` command for that), but as you're pretty much rewriting this file anyway, it probably does not matter in this case.



================
Comment at: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp:951-956
+    llvm::handleAllErrors(
+        exp_extractor.takeError(), [](const llvm::StringError &se) {
+          Log *log =
+              lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS);
+          LLDB_LOG(log, "{0}", se.getMessage());
+        });
----------------
As of now, we have an LLDB_LOG_ERROR macro, so you can write this as:
```
LLDB_LOG_ERROR(log, exp_extractor.takeError(), "Extracting return value failed: {0}");
```


https://reviews.llvm.org/D42468





More information about the llvm-commits mailing list