[PATCH] D41944: [LLVM][IR][LIT] support of 'no-overflow' flag for sdiv\udiv instructions

Mohammed Agabaria via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 23:04:57 PST 2018


magabari added a comment.

In https://reviews.llvm.org/D41944#991137, @MatzeB wrote:

> So do we still need all the .ll file changes with the syntax `nof`/`mof` syntax changes?


Technically No, any test which doesn't have 'mof' attribute (like: sdiv i32 %a, %b) will be treated as it have 'nof' attribute (backward compatibility).
I kept the changes to the lit tests only because I think it's more "correct" to declare explicitly that this divide has no overflow rather than relying on backward compatibility feature doing that.


https://reviews.llvm.org/D41944





More information about the llvm-commits mailing list