[PATCH] D42652: [WebAssembly] Make function signature checks into warning

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In https://reviews.llvm.org/D42652#991125, @ncw wrote:

> Sorry to poke my nose in, I'm just curious as to the rationale on why this shouldn't be a link error? We know for certain at this point that the output Wasm file won't validate, so we have effectively failed to link the inputs together.


Mostly because turning it on breaks so much existing code.  For example, musl has several such issues in it, which would mean that most of our tests on the wasm waterfall would stop linking if we enable this today.  For what its worth this is completely off by default right now.   So unless you explictly ask for it the linker will be silent about these errors.

I think it is a worthy goal to enable this by default one day.

Mostly I was looking for a warning to test the `--fatal-warnings` flag and these seemed like a good one because I imagine turning on by default as a warning first.   AFAICT there are no other warnings in the wasm linker today.. so maybe we don't need this flag at all?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42652