[PATCH] D42514: [ThinLTO/gold] Write empty imports even for modules with symbols

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 12:18:06 PST 2018


tejohnson added a comment.

I guess this is needed for the case when we need to split the module due to the existence of type metadata, but there is no module id so we can only write as regular LTO?



================
Comment at: llvm/tools/gold/gold-plugin.cpp:893
+      // build system.
+      writeEmptyDistributedBuildOutputs(Identifier, OldPrefix, NewPrefix);
     }
----------------
It would be good to avoid writing all these files unnecessarily (the common case). You could presumably get back from LTO::add (via addModule below) whether any module in the file had a summary (from the BitcodeLTOInfo structure in LTO::addModule).


https://reviews.llvm.org/D42514





More information about the llvm-commits mailing list