[PATCH] D42387: [AArch64] Add pipeline model for Exynos M3

[Evandro Menezes via Phabricator via llvm-commits]

evandro added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:678-679
     return MI.isAsCheapAsAMove();
-  if (Subtarget.getProcFamily() == AArch64Subtarget::ExynosM1 &&
+  if ((Subtarget.getProcFamily() == AArch64Subtarget::ExynosM1 ||
+       Subtarget.getProcFamily() == AArch64Subtarget::ExynosM3) &&
       isExynosShiftLeftFast(MI))
----------------
MatzeB wrote:
> Looks like it is time to make a subtarget feature out of this.
I agree in principle, but there already is `FeatureCustomCheapAsMoveHandling`, so I'm afraid that it might be a bit more involved and that it perhaps deserves a separate discussion.  Basically, these checks customize the custom handling of `isAsCheapAsAMove` because Exynos is different from the other AArch64 targets.


Repository:
  rL LLVM

https://reviews.llvm.org/D42387