[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

[Jim Ingham via Phabricator via llvm-commits]

jingham added a comment.

I see, thanks for the explanation of how things work on PPC.

Both Greg and my objection was that the code you are having to insert into the generic stepping algorithm - and will have to reproduce in the breakpoint setting/push past prologue code seems way too platform specific to be where it is in this patch (and will have to be for breakpoints as well.)  For instance, the thread plans have no business knowing that the all the entry points lie within the prologue of the main entry point, so you can always use that.

So we need to come up with a good abstraction for it.  In this case, it looks like you can figure out from the Symbol what the alternate entry points are, so my suggestion of putting it on the Function was wrong, it should be on the symbol.  But that seems like the reasonable actor to ask this question.  Then the Symbol's probably should ask the ABI (that was Greg's original suggestion.)


Repository:
  rL LLVM

https://reviews.llvm.org/D42582