[PATCH] D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 09:44:41 PST 2018


MatzeB added inline comments.


================
Comment at: test/CodeGen/X86/fixup-bw-inst.mir:204-246
+
+---
+# CHECK-LABEL: name: test5
+name:            test5
+alignment:       4
+exposesReturnsTwice: false
+legalized:       false
----------------
a.elovikov wrote:
> MatzeB wrote:
> > https://llvm.org/docs/MIRLangRef.html#simplifying-mir-files
> Thanks for the pointer. However, the whole file would benefit from this so I'd like to do the change in a subsequent commit. It should not require a review and can be directly committed, right?
Yes a change simplifying .mir like this is so obvious that it can be directly committed (aka post-commit review).


Repository:
  rL LLVM

https://reviews.llvm.org/D42533





More information about the llvm-commits mailing list