[PATCH] D42580: [ARM] Armv8.2-A FP16 code generation (part 2/3)

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

> Is your concern that I am changing the semantics of these nodes because I am omitting this convert?

Yes, it looks like you are using the same nodes, but giving them the semantics of a bitcast between i16 and f16. That's a problem, because there is existing code that teats them as floating-point extends/truncates between f32 and f16 (represented as i16 for legalisation reasons). Sooner or later, one of these nodes is going to be created by your new code and consumed by existing code, or vice-versa, and we will emit the wrong code.


https://reviews.llvm.org/D42580