[PATCH] D42233: [WebAssembly] Better support for WASM Object format

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: test/tools/llvm-objdump/wasm.txt:13
 # CHECK-NEXT:  7 CODE          00000019 0000000000000000 TEXT 
-# CHECK-NEXT:  8 DATA          0000001a 0000000000000000 DATA 
+# CHECK-NEXT:  8               00000014 0000000000000000 DATA 
 # CHECK-NEXT:  9 name          0000002b 0000000000000000 
----------------
patcheng wrote:
> Now Section.Name comes from DataSegment's Name, which is comes from linking. 
> 
> In `trivial.obj.wasm`, there is no names for the DataSegment, so it is currently returning nothing.
> 
> Should it default to "DATA"?
> 
> 
Maybe we should regenerate trivial.obj.wasm?  See test/tools/llvm-readobj/Inputs/trivial.ll  for how to do this


https://reviews.llvm.org/D42233