[PATCH] D42233: [WebAssembly] Better support for WASM Object format

Patrick Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 28 13:53:31 PST 2018


patcheng added inline comments.


================
Comment at: test/tools/llvm-objdump/wasm.txt:13
 # CHECK-NEXT:  7 CODE          00000019 0000000000000000 TEXT 
-# CHECK-NEXT:  8 DATA          0000001a 0000000000000000 DATA 
+# CHECK-NEXT:  8               00000014 0000000000000000 DATA 
 # CHECK-NEXT:  9 name          0000002b 0000000000000000 
----------------
Now Section.Name comes from DataSegment's Name, which is comes from linking. 

In `trivial.obj.wasm`, there is no names for the DataSegment, so it is currently returning nothing.

Should it default to "DATA"?




https://reviews.llvm.org/D42233





More information about the llvm-commits mailing list