[PATCH] D42564: [WebAssembly] ignore non-SymbolRef MCExpr.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 28 11:19:35 PST 2018


sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:446
 
-  assert(!IsPCRel);
   assert(SymA);
----------------
Why is this unnecessary?  Were you hitting this case?  Perhaps we need a test that triggers this?   Also, if this is unrelated to the MCSymbolRefExpr change than perhaps make it a separate change?


Repository:
  rL LLVM

https://reviews.llvm.org/D42564





More information about the llvm-commits mailing list