[llvm] r323576 - [InstrProfiling] Don't exit early when an unused intrinsic is found

[Vedant Kumar via llvm-commits]

Author: vedantk
Date: Fri Jan 26 16:01:04 2018
New Revision: 323576

URL: http://llvm.org/viewvc/llvm-project?rev=323576&view=rev
Log:
[InstrProfiling] Don't exit early when an unused intrinsic is found

This fixes a think-o in r323574.

Added:
    llvm/trunk/test/Instrumentation/InstrProfiling/early-exit.ll
Modified:
    llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp?rev=323576&r1=323575&r2=323576&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp Fri Jan 26 16:01:04 2018
@@ -434,13 +434,16 @@ void InstrProfiling::promoteCounterLoadS
 static bool containsProfilingIntrinsics(Module &M) {
   if (auto *F = M.getFunction(
           Intrinsic::getName(llvm::Intrinsic::instrprof_increment)))
-    return !F->use_empty();
+    if (!F->use_empty())
+      return true;
   if (auto *F = M.getFunction(
           Intrinsic::getName(llvm::Intrinsic::instrprof_increment_step)))
-    return !F->use_empty();
+    if (!F->use_empty())
+      return true;
   if (auto *F = M.getFunction(
           Intrinsic::getName(llvm::Intrinsic::instrprof_value_profile)))
-    return !F->use_empty();
+    if (!F->use_empty())
+      return true;
   return false;
 }
 

Added: llvm/trunk/test/Instrumentation/InstrProfiling/early-exit.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/InstrProfiling/early-exit.ll?rev=323576&view=auto
==============================================================================
--- llvm/trunk/test/Instrumentation/InstrProfiling/early-exit.ll (added)
+++ llvm/trunk/test/Instrumentation/InstrProfiling/early-exit.ll Fri Jan 26 16:01:04 2018
@@ -0,0 +1,15 @@
+; RUN: opt < %s -instrprof -S | FileCheck %s
+
+target triple = "x86_64-apple-macosx10.10.0"
+
+declare void @llvm.instrprof.increment(i8*, i64, i32, i32)
+
+declare void @llvm.instrprof.increment.step(i8*, i64, i32, i32, i64)
+
+ at __profn_foo = hidden constant [3 x i8] c"foo"
+
+define void @foo() {
+; CHECK: @__profc_foo = hidden global [1 x i64] zeroinitializer, section "__DATA,__llvm_prf_cnts", align 8
+  call void @llvm.instrprof.increment.step(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 0, i32 1, i32 0, i64 0)
+  ret void
+}