[PATCH] D42103: [LSR] Don't force bases of foldable formulae to the final type.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:4996
           isAMCompletelyFolded(TTI, LU, F)) {
-        Value *FullV = Rewriter.expandCodeFor(SE.getAddExpr(Ops), Ty);
+        Value *FullV = Rewriter.expandCodeFor(SE.getAddExpr(Ops), nullptr);
         Ops.clear();
----------------
I don't think this is what we want, FullV is supposed to have the same type as F.

That said, I would have expected your test case to have been recognized by the check line 4948.

Could you check why this is not happening?


https://reviews.llvm.org/D42103