[PATCH] D42603: [COFF] Update comment to reflect link.exe behavior. NFC

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 15:00:46 PST 2018


smeenai added a comment.

In https://reviews.llvm.org/D42603#989622, @ruiu wrote:

> I think what the original comment was trying to say is, emitting preserving a long section name (by emitting /<N> as the section name and put the real name at the N byte in the symbol table) would be useful for libunwind, though that's different from what we are doing now and what MSVC does.


IIRC the motivation for this change was actually the opposite. libunwind needed to determine the eh_frame section at runtime, but wasn't able to do so because of the string table not being loaded. @mstorsjo can confirm when he sees this though.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42603





More information about the llvm-commits mailing list