[llvm] r323555 - [X86] Allow any_extend to be combined with setcc on VLX targets.

[Craig Topper via llvm-commits]

Author: ctopper
Date: Fri Jan 26 12:02:52 2018
New Revision: 323555

URL: http://llvm.org/viewvc/llvm-project?rev=323555&view=rev
Log:
[X86] Allow any_extend to be combined with setcc on VLX targets.

For VLX target getSetccResultType returns vXi1 which prevents the target independent DAG combine from doing this tranform itself.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
    llvm/trunk/test/CodeGen/X86/avx512-calling-conv.ll

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=323555&r1=323554&r2=323555&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Jan 26 12:02:52 2018
@@ -36221,6 +36221,10 @@ static SDValue combineExtSetcc(SDNode *N
   EVT VT = N->getValueType(0);
   SDLoc dl(N);
 
+  // Only handle sext/aext for now.
+  if (N->getOpcode() != ISD::SIGN_EXTEND && N->getOpcode() != ISD::ANY_EXTEND)
+    return SDValue();
+
   // Only do this combine with AVX512 for vector extends.
   if (!Subtarget.hasAVX512() || !VT.isVector() || N0->getOpcode() != ISD::SETCC)
     return SDValue();
@@ -36474,6 +36478,10 @@ static SDValue combineZext(SDNode *N, Se
   if (SDValue NewCMov = combineToExtendCMOV(N, DAG))
     return NewCMov;
 
+  if (DCI.isBeforeLegalizeOps())
+    if (SDValue V = combineExtSetcc(N, DAG, Subtarget))
+      return V;
+
   if (SDValue V = combineToExtendVectorInReg(N, DAG, DCI, Subtarget))
     return V;
 

Modified: llvm/trunk/test/CodeGen/X86/avx512-calling-conv.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx512-calling-conv.ll?rev=323555&r1=323554&r2=323555&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/avx512-calling-conv.ll (original)
+++ llvm/trunk/test/CodeGen/X86/avx512-calling-conv.ll Fri Jan 26 12:02:52 2018
@@ -161,28 +161,16 @@ define <16 x i32> @test6(<16 x i32>%a, <
 declare <4 x i1> @func4xi1(<4 x i1> %a)
 
 define <4 x i32> @test7(<4 x i32>%a, <4 x i32>%b) {
-; KNL-LABEL: test7:
-; KNL:       ## %bb.0:
-; KNL-NEXT:    pushq %rax
-; KNL-NEXT:    .cfi_def_cfa_offset 16
-; KNL-NEXT:    vpcmpgtd %xmm1, %xmm0, %xmm0
-; KNL-NEXT:    callq _func4xi1
-; KNL-NEXT:    vpslld $31, %xmm0, %xmm0
-; KNL-NEXT:    vpsrad $31, %xmm0, %xmm0
-; KNL-NEXT:    popq %rax
-; KNL-NEXT:    retq
-;
-; SKX-LABEL: test7:
-; SKX:       ## %bb.0:
-; SKX-NEXT:    pushq %rax
-; SKX-NEXT:    .cfi_def_cfa_offset 16
-; SKX-NEXT:    vpcmpgtd %xmm1, %xmm0, %k0
-; SKX-NEXT:    vpmovm2d %k0, %xmm0
-; SKX-NEXT:    callq _func4xi1
-; SKX-NEXT:    vpslld $31, %xmm0, %xmm0
-; SKX-NEXT:    vpsrad $31, %xmm0, %xmm0
-; SKX-NEXT:    popq %rax
-; SKX-NEXT:    retq
+; ALL_X64-LABEL: test7:
+; ALL_X64:       ## %bb.0:
+; ALL_X64-NEXT:    pushq %rax
+; ALL_X64-NEXT:    .cfi_def_cfa_offset 16
+; ALL_X64-NEXT:    vpcmpgtd %xmm1, %xmm0, %xmm0
+; ALL_X64-NEXT:    callq _func4xi1
+; ALL_X64-NEXT:    vpslld $31, %xmm0, %xmm0
+; ALL_X64-NEXT:    vpsrad $31, %xmm0, %xmm0
+; ALL_X64-NEXT:    popq %rax
+; ALL_X64-NEXT:    retq
 ;
 ; KNL_X32-LABEL: test7:
 ; KNL_X32:       ## %bb.0: